Python: Add tox commands for code format and type checking #3282#3423
Python: Add tox commands for code format and type checking #3282#3423rdblue merged 1 commit intoapache:masterfrom
Conversation
|
One open question: Should we pin |
|
@cabhishek I think pinning makes sense! |
python/setup.cfg
Outdated
| classifiers = | ||
| License :: OSI Approved :: Apache Software License | ||
| Operating System :: OS Independent | ||
| Programming Language :: Python :: 3.6 |
There was a problem hiding this comment.
QQ, wondering if we should support 3.6? Per recent sync meeting, the plan is to support just py37,py38,py39 or higher versions.
There was a problem hiding this comment.
I would vote that we don't support 3.6 unless someone really feels we should. Looking at endoflife.date/python shows that python 3.6 security support ends in a little over a month.
There was a problem hiding this comment.
I think that we discussed this in one of the python syncs and we agreed that supporting 3.6 was a bad idea.
There was a problem hiding this comment.
Reverted changes and dropped 3.6 support.
cabhishek
force-pushed
the
enforce_code_standards
branch
from
a96da6e to
39ff690
Compare
samredai
left a comment
samredai
left a comment
There was a problem hiding this comment.
One small nit comment that I don't think needs to block merging this PR. LGTM! Thanks @cabhishek
python/tox.ini
Outdated
| bandit | ||
| commands = | ||
| bandit --ini tox.ini -r src | ||
| mypy src |
There was a problem hiding this comment.
nit: Should we add --no-implicit-optional here? This will require the explicit x: Optional[int] = None and will fail on x: int = None. The latter always reads odd to me, "must be an int, but by default it's None". The Optional type hint feels clearer.
There was a problem hiding this comment.
Added the flag. And given how common it is to have code like x: int = None I guess the future version of mypy will make that flag the default.
cabhishek
force-pushed
the
enforce_code_standards
branch
from
39ff690 to
ab95b58
Compare
|
Thanks, @cabhishek! |
4 participants
Uh oh!
There was an error while loading. Please reload this page.